Conversation
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
…oard nav link note Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
thecodrr
left a comment
There was a problem hiding this comment.
This PR is changing too many files (probably due to formatting). Can you undo the formatting changes so its easier to review things?
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
|
Thanks for pointing that out! I reverted the files just with formatting changes @thecodrr |
…tab there Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
… restore them Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
…hen moving to a new pane Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
…lines Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
|
@thecodrr I have seen that I accidentally formatted some minimized files that shouldn't have been in the commit. sorry for that The PR is now reduced to +3,327 −796 lines. Perhaps this isn't that scary anymore and you can have a look at it again? I will comment more in the coming days (running out of time now) |
|
@marcolaux sure! And yes, the "new window" logic should be postponed for now. I think it's an addon. Let's first get the split panes merged. |
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
|
@thecodrr could you have a look at the current state of this PR? I stripped out the whole multi window (and therefore many aspects with the window and database init) logic. Down to +2.708 -509 lines while I also added comments. |
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
Signed-off-by: Marco Laux <marco.laux@tiq-solutions.de>
|
Will take a look this week. |
Split panes
Notes List
Editor