web: disable desktop update checker if auto updates off#9302
Open
web: disable desktop update checker if auto updates off#9302
Conversation
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
thecodrr
requested changes
Feb 16, 2026
|
|
||
| checkingForUpdate(); | ||
| checkForUpdate().catch(console.error); | ||
| checkForUpdate(settingStore.get().autoUpdates).catch(console.error); |
Contributor
There was a problem hiding this comment.
Are we sure that autoUpdates has the updated value here? If not then it won't ever check for updates on startup.
Contributor
Author
There was a problem hiding this comment.
that was a nice catch, thanks!
I'm now using a listener so we can guarantee the latest value. One side-ffect is that update checker will run anytime the value changes, which I don't think should be a huge issue
… value Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9285