Open
Conversation
thecodrr
force-pushed
the
fix/password-changing
branch
from
87370c8 to
16b6b37
Compare
ammarahm-ed
force-pushed
the
fix/password-changing
branch
from
0b4fcc1 to
5153b43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a backward compatible step that migrates all users to DEK based encryption. Previously, we were encrypting everything with the master key which required everything to be re-encrypted on password change resulting in potential data loss. We are changing that by encrypting data first with DEK and then encrypting the DEK with the master key. Changing the master key will only require reencrypting the DEK - not the data. This also means that password changing is now bullet proof.
This change won't come into effect unless user performs a password change so for most users things should continue to work as before.