Add CollectT.Halt() as a fail-fast helper for EventuallyWithT #1830
+74
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
CollectT.Halt()so fatal assertions invoked insideEventuallyWithTcan stop the retry loop.Changes
Add the new
HaltTstruct that acts as aCollectTwrapper. Whenever an error or failure is recorded, the wrappingHaltTwill setCollectT's newhaltflag, so that theEventuallyWithTloop can detect this and error out early.Motivation
This allows for cleanly breaking out of the test loop before the timeout has elapsed, if necessary:
Related issues
requireassertions when usingassert.EventuallyWithT#1396