assert: return error instead of panicking on invalid regexp#1849
Open
veeceey wants to merge 1 commit intostretchr:masterfrom
Open
assert: return error instead of panicking on invalid regexp#1849veeceey wants to merge 1 commit intostretchr:masterfrom
veeceey wants to merge 1 commit intostretchr:masterfrom
Conversation
matchRegexp uses regexp.MustCompile which panics on invalid regular expressions. This is inappropriate for a test assertion - the test should fail with a clear error message instead. Switch from regexp.MustCompile to regexp.Compile and return the compilation error. Regexp and NotRegexp now report the invalid pattern via Fail instead of crashing the test process. Fixes stretchr#1794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1794
RegexpandNotRegexpuseregexp.MustCompileinternally, which panics when the regex pattern is invalid. For a test assertion, this is pretty surprising -- you'd expect the test to just fail with a useful error rather than crash the whole process.The fix switches
matchRegexpfromregexp.MustCompiletoregexp.Compileand threads the error back to the callers.RegexpandNotRegexpnow callFailwith a message showing the invalid pattern and the compilation error, instead of panicking.Added test cases for both
RegexpandNotRegexpwith an invalid pattern.