Update node to 22+ #632
Update node to 22+ #632
Conversation
|
jrdrew seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
bin/reset_dev
Outdated
| mix deps.get | ||
| mix deps.compile | ||
| mix compile No newline at end of file | ||
| rm -rf _build/ && mix deps.clean --all && mix deps.get && mix deps.compile && mix compile No newline at end of file |
There was a problem hiding this comment.
Good question. Probably an auto-formatter/linter making this change, I would guess?
The only difference I see is that the new version is dependent on the former steps/invocations completing successfully before executing the next one in sequence. The original would still execute the statements regardless of whether or not the prior one(s) completed successfully or not. Generally, that's not what we want I would think.
| # install project version of node (18.19.0) and use it | ||
| nvm install 18.19.0 && nvm use 18.19.0 | ||
| # install project version of node (22.0.0) and use it | ||
| nvm install 22.0.0 && nvm use 22.0.0 |
There was a problem hiding this comment.
Does nvm use .tool-versions file? I believe asdf introduced this file and is part of the instructions for managing erlang and elixir.
There was a problem hiding this comment.
NVM would use an .nvmrc file. We no longer need the .tool-versions file since we eliminated ASDF.
package.json
Outdated
| @@ -1,4 +1,7 @@ | |||
| { | |||
| "engines": { | |||
| "node": ">=22" | |||
There was a problem hiding this comment.
Should this be pinned at 22? Are we targeting LTS or trying to upgrade more frequently?
Description of Change(s) Introduced:
Updated the node version 22