fix: Ensure cached data is up to date when models are mutated#2936
Merged
Eideren merged 2 commits intostride3d:masterfrom Oct 27, 2025
Merged
fix: Ensure cached data is up to date when models are mutated#2936Eideren merged 2 commits intostride3d:masterfrom
Eideren merged 2 commits intostride3d:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Running the following
throws when a
ModelComponentwas already in the scene in the preceding frame.Fixes other similar errors, like when swapping one of the mesh, or one of the meshes' draw.
Also refactored around one of the failing method a bit to improve readability, splitting the logic into two explicit sections by flattening the inner scopes.
Related Issue
None.
Types of changes
Checklist