feat: Add unit tests in Core to increase coverage#2967
Merged
xen2 merged 9 commits intostride3d:masterfrom Dec 3, 2025
Merged
Conversation
e56cbff to
a20e685
Compare
Generated with the help of GitHub Copilot & Claude Sonnet 4.5
The static Negate method was copy-pasted from the Normalize method and was performing normalization (making the normal vector unit length) instead of negation (flipping all coefficients).
Generated with the help of GitHub Copilot & Claude Sonnet 4.5
Generated with the help of GitHub Copilot & Claude Sonnet 4.5
a20e685 to
e056066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Improve the code coverage of
Stride.Core.CompilerServices,Stride.Core.DesignandStride.Core.Mathematics.Details
Tests were written with the help of GitHub Copilot. It also helped detect some issue in Core.Mathematics.
One is already tracked #2672. Fixing it would potentially be a breaking change, so it wasn't done in this PR.
Another was that
Plane.Negate(Plane)wasn't negating the plane, but instead normalizing it, likely because of an unfortunate copy/paste. I decided to fix it since it was never correct before.HybridDictionaryalso has a few issues, like throwing when initializing with a zero capacity (which should be allowed).Overall, we now have a very good coverage for Mathematics and CompilerServices, and a passable coverage for Design:
Before that PR, the coverage was:
Types of changes
Checklist