Conversation
Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
scholzj
left a comment
There was a problem hiding this comment.
I'm not entirely sure why did you changed location to path. I'm pretty flexible and can use both. But given Kafka uses location, I wonder if that was better? (that said, the option names anyway differ, so maybe we don't care?)
| |http.ssl.keystore.certificate.chain | ||
| |The HTTP Bridge server keystore certificate in PEM format. | ||
| PEM is the only format supported for keystore. | ||
| |http.ssl.certificate |
There was a problem hiding this comment.
So, if we call this http.ssl.certificate / http.ssl.certificate.path ... how would we call the trusted certificates if we one day add support for mTLS authentication?
|
@tinaselenge I had a view and my thoughts are:
Tbh at this point I am not sure why we are making these changes here. |
|
I think the confusion here is that the settings are similar to the Kafka settings, but actually the way the user provides them is different from Kafka. So for example in Kafka you can provide these configurations for files: Where So given the starting point I'm not sure what can be changed to make it less confusing |
Based on the recent discussion, naming for some of the SSL properties were confusing as they mix "keystore" terminology with PEM certificate/key terminology. This PR attempts to make them clearer, with more consistent terminology.
In the future, if we need to support more formats (not sure if we will ever need to do), we could add: