Add test for ConfigModel INT type pattern validation#12584
Open
archy-rock3t-cloud wants to merge 1 commit intostrimzi:mainfrom
Open
Add test for ConfigModel INT type pattern validation#12584archy-rock3t-cloud wants to merge 1 commit intostrimzi:mainfrom
archy-rock3t-cloud wants to merge 1 commit intostrimzi:mainfrom
Conversation
Signed-off-by: Artem Muterko <artem@sopho.tech>
scholzj
reviewed
Mar 30, 2026
Member
scholzj
left a comment
scholzj
left a comment
There was a problem hiding this comment.
Thanks for the PR. However, what value does the test really add? The pattern handling does not really differ based on type, as it is handled the same way regardless of the type, given that it actually validates Strings. I think it is also checked in KafkaConfigurationTests on a specific Kafka example that uses int (compression.gzip.level).
Member
|
Yeah I agree that this seems to be covered in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The INT type supports a pattern constraint but had no test exercising it.
Checklist