Skip to content

Fix permission on kafka-scripts#43

Merged
see-quick merged 1 commit intomainfrom
fix-permissions-in-images
Jan 28, 2026
Merged

Fix permission on kafka-scripts#43
see-quick merged 1 commit intomainfrom
fix-permissions-in-images

Conversation

@see-quick
Copy link
Member

@see-quick see-quick commented Jan 28, 2026

It seems that during GHA migration when downloading kafka-binaries we do not execute permissions are lost as in GHA we did split across jobs (in Azure there is just one job). This change should fix it.

The problem was spotten in test-container build where most of the tests failed with:

2026-01-28 09:29:38 ERROR [1:544] Log output from the failed container:
/testcontainers_start.sh: line 2: bin/kafka-storage.sh: Permission denied
/testcontainers_start.sh: line 3: bin/kafka-server-start.sh: Permission denied

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick added this to the 0.115.0 milestone Jan 28, 2026
@see-quick see-quick self-assigned this Jan 28, 2026
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@see-quick This seems prett strange solution. Why is this needed only in GitHub Actions and not in local builds etc.?

@see-quick
Copy link
Member Author

@see-quick This seems prett strange solution. Why is this needed only in GitHub Actions and not in local builds etc.?

It appears that when you upload or download an artefact using GHA, the +x permissions are excluded. At least that's what I have got from [1]. I am double-checking the builded artifacts from this PR, but the internet is somehow veeery slow as ... :/

[1] - actions/upload-artifact#38

@scholzj
Copy link
Member

scholzj commented Jan 28, 2026

@see-quick Ahh. Makes sense. Thanks.

@see-quick see-quick merged commit d2cd2ce into main Jan 28, 2026
10 checks passed
@see-quick see-quick deleted the fix-permissions-in-images branch February 18, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants