Add ScriptPubkey

Author: stringintech

TODO.md

@@ -19,18 +19,13 @@ This document lists the remaining C API functions and data structures from `bitc
 ## Missing Data Structures
 
 ### Core Transaction Types
-- **`kernel_ScriptPubkey`** - Script public key operations  
 - **`kernel_TransactionOutput`** - Transaction output operations
 - **`kernel_BlockPointer`** - Non-owned block pointers (from callbacks)
 - **`kernel_BlockUndo`** - Block undo data operations
-- **`kernel_ByteArray`** - Helper for serialized data
 
 ## Missing Functions by Category
 
 ### Script Operations
-- [ ] `kernel_script_pubkey_create()` - Create script pubkey
-- [ ] `kernel_script_pubkey_destroy()` - Cleanup script pubkey  
-- [ ] `kernel_copy_script_pubkey_data()` - Get serialized script data
 - [ ] `kernel_verify_script()` - **Script verification (IMPORTANT!)**
 
 ### Transaction Output Operations

kernel/errors.go

@@ -21,4 +21,8 @@ var (
 	ErrLoggingConnectionCreation        = errors.New("failed to create logging connection")
 	ErrTransactionCreation              = errors.New("failed to create transaction from raw data")
 	ErrInvalidTransactionData           = errors.New("invalid transaction data")
+	ErrScriptPubkeyCreation             = errors.New("failed to create script pubkey from raw data")
+	ErrInvalidScriptPubkeyData          = errors.New("invalid script pubkey data")
+	ErrInvalidScriptPubkey              = errors.New("invalid script pubkey")
+	ErrScriptPubkeyDataCopy             = errors.New("failed to copy script pubkey data")
 )

kernel/script_pubkey.go

@@ -0,0 +1,65 @@
+package kernel
+
+/*
+#include "kernel/bitcoinkernel.h"
+*/
+import "C"
+import (
+	"runtime"
+	"unsafe"
+)
+
+// ScriptPubkey wraps the C kernel_ScriptPubkey
+type ScriptPubkey struct {
+	ptr *C.kernel_ScriptPubkey
+}
+
+// NewScriptPubkeyFromRaw creates a new script pubkey from raw serialized data
+func NewScriptPubkeyFromRaw(rawScriptPubkey []byte) (*ScriptPubkey, error) {
+	if len(rawScriptPubkey) == 0 {
+		return nil, ErrInvalidScriptPubkeyData
+	}
+
+	ptr := C.kernel_script_pubkey_create((*C.uchar)(unsafe.Pointer(&rawScriptPubkey[0])), C.size_t(len(rawScriptPubkey)))
+	if ptr == nil {
+		return nil, ErrScriptPubkeyCreation
+	}
+
+	scriptPubkey := &ScriptPubkey{ptr: ptr}
+	runtime.SetFinalizer(scriptPubkey, (*ScriptPubkey).destroy)
+	return scriptPubkey, nil
+}
+
+// Data returns the serialized script pubkey data
+func (s *ScriptPubkey) Data() ([]byte, error) {
+	if s.ptr == nil {
+		return nil, ErrInvalidScriptPubkey
+	}
+
+	byteArray := C.kernel_copy_script_pubkey_data(s.ptr)
+	if byteArray == nil {
+		return nil, ErrScriptPubkeyDataCopy
+	}
+	defer C.kernel_byte_array_destroy(byteArray)
+
+	size := int(byteArray.size)
+	if size == 0 {
+		return nil, nil
+	}
+
+	// Copy the data to Go slice
+	data := C.GoBytes(unsafe.Pointer(byteArray.data), C.int(size))
+	return data, nil
+}
+
+func (s *ScriptPubkey) destroy() {
+	if s.ptr != nil {
+		C.kernel_script_pubkey_destroy(s.ptr)
+		s.ptr = nil
+	}
+}
+
+func (s *ScriptPubkey) Destroy() {
+	runtime.SetFinalizer(s, nil)
+	s.destroy()
+}

kernel/script_pubkey_test.go

@@ -0,0 +1,44 @@
+package kernel
+
+import (
+	"encoding/hex"
+	"errors"
+	"testing"
+)
+
+func TestInvalidScriptPubkeyData(t *testing.T) {
+	// Test with empty data
+	_, err := NewScriptPubkeyFromRaw([]byte{})
+	if !errors.Is(err, ErrInvalidScriptPubkeyData) {
+		t.Errorf("Expected ErrInvalidScriptPubkeyData, got %v", err)
+	}
+}
+
+func TestScriptPubkeyFromRaw(t *testing.T) {
+	scriptHex := "76a914389ffce9cd9ae88dcc0631e88a821ffdbe9bfe26158088ac"
+	scriptBytes, err := hex.DecodeString(scriptHex)
+	if err != nil {
+		t.Fatalf("Failed to decode script hex: %v", err)
+	}
+
+	scriptPubkey, err := NewScriptPubkeyFromRaw(scriptBytes)
+	if err != nil {
+		t.Fatalf("NewScriptPubkeyFromRaw() error = %v", err)
+	}
+	defer scriptPubkey.Destroy()
+
+	// Test getting script pubkey data
+	data, err := scriptPubkey.Data()
+	if err != nil {
+		t.Fatalf("ScriptPubkey.Data() error = %v", err)
+	}
+
+	if len(data) != len(scriptBytes) {
+		t.Errorf("Expected data length %d, got %d", len(scriptBytes), len(data))
+	}
+
+	hexStr := hex.EncodeToString(data)
+	if hexStr != scriptHex {
+		t.Errorf("Expected data hex: %s, got %s", scriptHex, hexStr)
+	}
+}