Skip to content

plural function now raises ValueError for negative n #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yanuttle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

plural function now raises ValueError for negative n #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mallard/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ async def on_ready(self):
logger.info("Ready! \U0001f986")

def _clean(self, message) -> Optional[str]:
"""
Filter mention from query
"""
if message.author == self.user:
return None
if not message.content:
Expand Down
2 changes: 1 addition & 1 deletion mallard/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import yaml


def load_config(path):
def load_config(path) -> dict:
with open(path, "r") as fh:
obj = yaml.safe_load(fh)

Expand Down
13 changes: 11 additions & 2 deletions mallard/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,21 @@
# WITHOUT ANY WARRANTY. See the LICENSE file for more details.
#

import logging

def plural(n) -> str:
logger = logging.getLogger("mallard")


def plural(n: int) -> Optional[str]:
if n == 1:
return ""
else:
elif n > 0:
return "s"
else:
logger.error("plural() passed value: %d, n should be a positive integer", n)
raise ValueError(
"n must be a positive integer"
) # this will actuall never happen


class DummyGuild:
Expand Down