This repository was archived by the owner on Jan 23, 2021. It is now read-only.
Ensure Webhooks are received from a whitelisted IP address #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add guard to Webhook receipt endpoint which ensures that the sender appears on Stripe's whitelist - Add `request` dependency
willock-stripe
commented
May 10, 2019
| console.log( | ||
| chalk.red('Received webhook from a non-whitelisted IP, ignoring.') | ||
| ); | ||
| return; |
There was a problem hiding this comment.
Maybe this should return a 400 response.
|
@mg-stripe – erring on the side of "this probably shouldn't live in the application code", but take a look if you're interested! |
|
@mg-stripe let me know if you get a moment to :ponder: this, please! Happy just to close it out if it doesn't make sense. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a simple guard to ensure that Webhooks are only processed when received from a verified, whitelisted IP address. This makes use of the documented
ips_webhooks.jsonresource, which can be programatically fetched for the purposes of configuringiptables, etc.Much like #5, this isn't something that you might necessarily want to do in a debugging tool (or even at the application layer!), but piqued my curiosity. Feel free to ignore or close!
Changes
requestdependency