Add custom timeout for tmpdb's database drops #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplunkett-stripe
approved these changes
Jul 15, 2025
Collaborator
bplunkett-stripe
left a comment
bplunkett-stripe
left a comment
There was a problem hiding this comment.
LGTM! I could imagine folks --might-- want this as a CLI parameter in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add an option to set statement timeout for database drop of the tempdb.
Motivation
When using pg-schema-diff on an azure managed database, the database drop statement take time (around 10s), generating error when using pg-schema-diff (and creating strange shadow databases).
With this, any suitable timeouts can be set depending on user context.
Testing
Tested locally in my context, 'issue' is fixed.
No unit test because it seems hard to test, but I'm open to suggestions.