Skip to content

Conversation

@jar-stripe
Copy link
Contributor

Why?

There was an issue in our code generator where custom methods inside child resources would be missing overloads that accept the child resource id and RequestOptions. This PR includes the generated code after addressing that issue. This doesn't add any net new functionality (it is functionally equivalent to the overload that only accepts the child resource id), but it is more in line with the tests in StandardizedTests.

What?

  • adds Customer retrievePaymentMethod overload that takes payment method id and request options
  • removes "retrieve" special case from StandardizedTest allNonDeprecatedMethodsTakeOptions

See Also

Changelog

  • Adds retrievePaymentMethod overload to Customer that accepts a payment method id and RequestOptions object

@jar-stripe jar-stripe changed the title Adds Customer retrievePaymentMethod overload Adds generated Customer retrievePaymentMethod overload May 27, 2025
@jar-stripe jar-stripe marked this pull request as ready for review May 27, 2025 16:38
@jar-stripe jar-stripe requested a review from a team as a code owner May 27, 2025 16:38
@jar-stripe jar-stripe requested review from prathmesh-stripe and removed request for a team May 27, 2025 16:38
@jar-stripe jar-stripe enabled auto-merge (squash) May 27, 2025 16:38
@jar-stripe jar-stripe disabled auto-merge May 27, 2025 16:39
@jar-stripe jar-stripe enabled auto-merge (squash) May 27, 2025 16:39
@jar-stripe jar-stripe merged commit 49a6a12 into master May 27, 2025
14 checks passed
@jar-stripe jar-stripe deleted the jar/fix-overloads-for-custom-methods branch May 27, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants