Skip to content

Conversation

@xavdid-stripe
Copy link
Member

@xavdid-stripe xavdid-stripe commented Sep 5, 2025

Why?

While SDK support for our v1 APIs comes from our public openapi spec, our v2 endpoints have been sources from an internal dump of the protobuf definitions of those APIs.

This PR marks our cutover point for our generation source: now we're using the (private, for now) V2 OpenAPI spec! There are a few changes/bugfixes as a result (documented below).

note: entire PR is codegen

What?

  • generated SDK using v2 openapi spec.

See Also

DEVSDK-2750

Changelog

  • ⚠️ The delete methods for v2 APIs (the ones in the StripeClient.v2 namespace) now return a V2DeletedObject which has the id of the object that has been deleted and a string representing the type of the object that has been deleted.
  • ⚠️ Query params on v2 APIs (like limit) are now Long instead of Integer (to match v1 APIs)
  • ⚠️ Deeply nested param hashes with no properties no longer have classes generated for them. Instead, they're typed as Map<String, Object>. Because there were no params, it's unlikely you were using these classes.

@xavdid-stripe xavdid-stripe marked this pull request as ready for review September 5, 2025 21:30
@xavdid-stripe xavdid-stripe requested a review from a team as a code owner September 5, 2025 21:30
@xavdid-stripe xavdid-stripe requested review from mbroshi-stripe and removed request for a team September 5, 2025 21:30
@xavdid-stripe xavdid-stripe enabled auto-merge (squash) September 5, 2025 21:30
@xavdid-stripe xavdid-stripe changed the title Build SDK w/ V2 OpenAPI spec ⚠️ Build SDK w/ V2 OpenAPI spec Sep 5, 2025
@xavdid-stripe xavdid-stripe merged commit 4c35bc3 into master Sep 8, 2025
22 of 25 checks passed
@xavdid-stripe xavdid-stripe deleted the DEVSDK-2750 branch September 8, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants