Throw ApiKeyMissingException instead of IllegalArgumentException for unset API keys
#2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elnafateh
requested review from
xavdid-stripe
and removed request for
a team
|
|
Member
|
@elnafateh this looks good! you need to sign the CLA (see above comment) and then I can get it merged. |
Contributor
Author
|
@xavdid-stripe it's done |
xavdid-stripe
approved these changes
Sep 18, 2025
xavdid-stripe
changed the title
ApiKeyMissingException instead of IllegalArgumentException for unset API keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
BearerTokenAuthenticatorthrew an IllegalArgumentException with a vague message when given a null API key. This was inconsistent with the rest of the SDK.What?
Notes
Future Work
A possible improvement for multi-tenant environments would be allowing StripeClient construction without requiring a global API key, instead relying solely on RequestOptions for per-request keys.
Changelog
ApiKeyMissingExceptioninstead ofIllegalArgumentExceptionwhen making a request before setting an API key initializing a client without an API key. Tweak the wording of that message to better indicate how to fix.