Add StripeContext object
#2057
Merged
Add StripeContext object
#2057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
requested review from
mbroshi-stripe
and removed request for
a team
Contributor
mbroshi-stripe
left a comment
mbroshi-stripe
left a comment
There was a problem hiding this comment.
Overall feedback is that I'd keep a single representation of StripeContext that does the right thing when it comes to serialization/deserialization rather than switching between object and string representations internally.
Member
Author
|
ok, should be all set! |
mbroshi-stripe
approved these changes
Sep 25, 2025
Contributor
mbroshi-stripe
left a comment
mbroshi-stripe
left a comment
There was a problem hiding this comment.
Looks great! Thanks for incorporating the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
As the
stripe-contextheader is evolving, we want to give better tools for creating and managing contexts. This PR adds a new class,StripeContext. It can be used anywhere the context option is supplied and gets serialized to a string when making requests. It's also found on theEventNotification.contextproperty.What?
StripeContextclassChangelog
StripeContextclass. Previously, you could set the stripe context only as a string viaStripeClientBuilder .setStripeContext(). The same method can now take an instance of theStripeContextclass as wellEventNotification(formerly known asThinEvent)'scontextproperty fromstringtoStripeContext