Add Automatic-Module-Name to manifest entry #2121
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroshi-stripe
requested review from
prathmesh-stripe
and removed request for
a team
prathmesh-stripe
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
It was brought up in #1220 (4.5 years ago!) that our
stripe-javajar is missing anAutomatic-Module-Namemanifest entry. For Java 9+, that means that consumers must use an inferred name of the module based on the compiled jar name, which is brittle. By addingAutomatic-Module-Name: stripe.java, consumers and their tooling can confidently depend on that module name.In the future, we can consider using a more conventional name like
com.stripe, but that could technically break some users that have an explicitrequires stripe.java;in theirmanifest-info.java.What?
Automatic-Module-Name: stripe.javato the jar's manifest entry