Import global configuration for options not available on StripeClient options#1512
Merged
helenye-stripe merged 6 commits intomasterfrom Jan 13, 2025
Merged
Import global configuration for options not available on StripeClient options#1512helenye-stripe merged 6 commits intomasterfrom
helenye-stripe merged 6 commits intomasterfrom
Conversation
helenye-stripe
changed the title
helenye-stripe
requested review from
a team and
xavdid-stripe
and removed request for
a team
xavdid-stripe
approved these changes
Jan 10, 2025
helenye-stripe
force-pushed
the
helenye-fix-options
branch
from
7c9a7e6 to
68db5c4
Compare
helenye-stripe
force-pushed
the
helenye-fix-options
branch
from
68db5c4 to
ca96e72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Raised in #1511 - In our v13 migration guide, we mention that we use global configuration for options that are not available per StripeClient. This was not implemented for that release, this remedies that.
What?
Adds a new fxn and tests to StripeConfiguration to initialize a client configuration with given options, with each option following the priority:
enable_telemetry,open_timeout)See Also
Changelog
StripeClientwas not falling back to global options for options that are not available to be set per-client