Skip to content

Optimize Util.valid_variable_name? method #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathmesh-stripe merged 1 commit into from
Feb 19, 2026
Merged

Optimize Util.valid_variable_name? method #1782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions lib/stripe/util.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@

module Stripe
module Util
LEGAL_FIRST_CHARACTER = /[a-zA-Z_]/.freeze
LEGAL_VARIABLE_CHARACTER = /[a-zA-Z0-9_]/.freeze

def self.objects_to_ids(obj, serialize_empty: false)
case obj
when APIResource
Expand Down Expand Up @@ -329,9 +326,7 @@ def self.normalize_opts(opts)
# Return false for strings that are invalid variable names
# Does NOT expect there to be a preceding '@' for instance variables
def self.valid_variable_name?(key)
return false if key.empty? || key[0] !~ LEGAL_FIRST_CHARACTER

key[1..].chars.all? { |char| char =~ LEGAL_VARIABLE_CHARACTER }
key.match?(/\A[a-zA-Z_]\w*\z/)
end

def self.check_string_argument!(key)
Expand Down