Fix v2 typed params sending nil values on GET requests#1788
Merged
mbroshi-stripe merged 1 commit intoprivate-previewfrom Feb 16, 2026
Merged
Fix v2 typed params sending nil values on GET requests#1788mbroshi-stripe merged 1 commit intoprivate-previewfrom
mbroshi-stripe merged 1 commit intoprivate-previewfrom
Conversation
objects_to_ids was preserving nil values for all v2 API requests, but this caused issues on GET requests where nil values become empty strings in query parameters, leading to API errors like: "limit: Expected an Integer value got: ." This change updates the logic to only preserve nil values in the request body (for POST/PUT/PATCH requests) where they are needed for v2 semantics, while filtering them from query parameters (for GET/HEAD/DELETE requests). Changed from symbol-based semantics parameter to a boolean serialize_empty parameter for clarity. Committed-By-Agent: claude
mbroshi-stripe
requested review from
jar-stripe
and removed request for
a team
jar-stripe
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
See #1786
What?
nilvalues on V2 GET requestsChangelog
nilquery parameters as empty strings. The server would return an error in such cases like'limit: Expected an Integer value got: .'