Skip to content

- Added coverage for Build and Deploy#1473

Open
matttt wants to merge 12 commits intomasterfrom
feature/build-deploy-e2e-tests
Open

- Added coverage for Build and Deploy#1473
matttt wants to merge 12 commits intomasterfrom
feature/build-deploy-e2e-tests

Conversation

@matttt
Copy link
Copy Markdown
Contributor

@matttt matttt commented Jul 31, 2015

  • Increased overall stability
  • Seperated tests into long and short run suites

@seanbrookes seanbrookes self-assigned this Jul 31, 2015
seanbrookes
seanbrookes reviewed Jul 31, 2015
View reviewed changes
client/test/e2e/process-manager/build-test-app.spec.js
Copy link
Copy Markdown
Contributor

@seanbrookes seanbrookes Jul 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a variable

@seanbrookes seanbrookes assigned matttt and unassigned seanbrookes Jul 31, 2015
@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Jul 31, 2015

test please

2 similar comments
@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 4, 2015

test please

@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 5, 2015

test please

@sam-github
Copy link
Copy Markdown
Contributor

sam-github commented Aug 5, 2015

@seanbrookes @matttt client/test/empty-0.0.0.tgz is a large binary, its slow to clone, and generally worth keeping large binaries out of git if at all possible. Is it necessary that it be committed? Can it be built by a pretest script, perhaps a pretest script that calls a grunt task?

Or, since it appears to be a node app, can it just be made a dev dependency of strong-arc?

@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 5, 2015

that file is a product of the testing process and shouldn't be committed

@matttt matttt force-pushed the feature/build-deploy-e2e-tests branch from 4cc25f1 to 02a3602 Compare August 5, 2015 21:50
@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 7, 2015

test please

@seanbrookes seanbrookes force-pushed the feature/build-deploy-e2e-tests branch from 02a3602 to af90f5e Compare August 12, 2015 18:15
@seanbrookes seanbrookes assigned seanbrookes and unassigned matttt Aug 12, 2015
@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 12, 2015

test please

@seanbrookes seanbrookes force-pushed the feature/build-deploy-e2e-tests branch from 1db2363 to b0e0498 Compare August 12, 2015 21:51
@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 13, 2015

test please

@seanbrookes seanbrookes force-pushed the feature/build-deploy-e2e-tests branch from b0e0498 to e2bd0dc Compare August 14, 2015 15:39
@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 14, 2015

test please

@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 14, 2015

test please

rmg
rmg reviewed Aug 14, 2015
View reviewed changes
gulpfile.js Outdated
Copy link
Copy Markdown
Member

@rmg rmg Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path doesn't exist when this is run, so spawn() can't cd into it to run the test server.

Copy link
Copy Markdown
Contributor

@seanbrookes seanbrookes Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why that code was added to the gulp task

Copy link
Copy Markdown
Member

@rmg rmg Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither, it passes without that line being changed :-)

@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 14, 2015

test please

@seanbrookes
Copy link
Copy Markdown
Contributor

seanbrookes commented Aug 15, 2015

test please

@anthonyettinger
Copy link
Copy Markdown
Contributor

anthonyettinger commented Sep 10, 2015

Please dont' use browser.sleep You should use browser.waitForAngular() instead

@chandadharap chandadharap assigned jtary and unassigned seanbrookes Oct 19, 2015
@jtary jtary added #plan and removed #review labels Oct 26, 2015
@jtary jtary added #tob and removed #plan labels Nov 2, 2015
@cgole cgole removed the #tob label Jan 7, 2017
@rmg rmg unassigned jtary Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@matttt @seanbrookes @sam-github @anthonyettinger @rmg @jtary @cgole @altsang