onError and Support for mam 1 #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the possibility to use urn:xmpp:mam:1 and added an onError method.
jcbrand
reviewed
Dec 20, 2017
Contributor
jcbrand
left a comment
jcbrand
left a comment
There was a problem hiding this comment.
Thanks for the pull request. Please see my two review comments.
| * | ||
| */ | ||
| import { $iq, Strophe } from 'strophe.js'; | ||
| //import { $iq, Strophe } from 'strophe.js'; NOTE: Can make issues on some systems |
Contributor
There was a problem hiding this comment.
You can't just comment this out...
Either create a ticket where you explain what the problem is, or make a separate pull request for specifically this issue.
| iq.c('field',{var:'FORM_TYPE', type:'hidden'}).c('value').t(Strophe.NS.MAM).up().up(); | ||
| var ns = Strophe.NS.MAM; | ||
| if ( options.oldVersion ) | ||
| ns = 'urn:xmpp:mam:1'; |
Contributor
There was a problem hiding this comment.
Did you introduce the oldVersion option? Doesn't look like it's documented anywhere. Additionally, it's unnecessarily vague. Instead of oldVersion, perhaps the actual version number could be specified?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to use urn:xmpp:mam:1 and added an onError method.