Open
Conversation
jatinkatyal13
requested changes
Aug 13, 2023
| const { examinationIds, eventId } = this.request.body; | ||
|
|
||
| const order = await _ordersService.createOrder(examinationIds, this.request.user.id); | ||
| const order = await _ordersService.createOrder({ |
Contributor
There was a problem hiding this comment.
Would need to check if event has expired or not based on endDate
Contributor
Author
There was a problem hiding this comment.
this has been already taken care inside api/services/orders/index.js
api/services/orders/index.js
Outdated
| ); | ||
| const event = await DB.events.findByPk(eventId); | ||
|
|
||
| const amount = event.primaryPrice * 100 + event.secondaryPrice * 100; |
Contributor
There was a problem hiding this comment.
amount = primaryPrice + ((numOfExams-1) * secondaryPrice)
Contributor
Author
There was a problem hiding this comment.
why do we want to numOfExams-1?
because student can choose only 1 exam as well?
Contributor
There was a problem hiding this comment.
First exam would be primary price rest would be secondary
Contributor
There was a problem hiding this comment.
Basically
- If student purchases 1 exam, amount = primary price
- purchases 2 exams, amount = primary + secondary
- purchases 3 exams, amount = primary + (2 * secondary)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.