Skip to content

Fix double encoding in filter_plugin_action_links #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szepeviktor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix double encoding in filter_plugin_action_links #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions wp-user-activity/includes/sponsor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,11 @@
*/
function filter_plugin_action_links( $actions = array() ) {

// Sponsor text
$text = esc_html_x( 'Sponsor', 'verb', 'wp-user-activity' );

// Sponsor URL
$url = 'https://buy.stripe.com/7sI3cd2tK1Cy2lydQR';
$url = 'https://buy.stripe.com/7sI3cd2tK1Cy2lydQR';

// Merge links & return
return array_merge( $actions, array(
'sponsor' => '<a href="' . esc_url( $url ) . '">' . esc_html( $text ) . '</a>'
'sponsor' => '<a href="' . esc_url( $url ) . '">' . esc_html_x( 'Sponsor', 'verb', 'wp-user-activity' ) . '</a>'
Copy link
Contributor Author

@szepeviktor szepeviktor Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'sponsor' => '<a href="' . esc_url( $url ) . '">' . esc_html_x( 'Sponsor', 'verb', 'wp-user-activity' ) . '</a>'
'sponsor' => sprintf( '<a href="%s">%s</a>', esc_url( $url ), esc_html_x( 'Sponsor', 'verb', 'wp-user-activity' ) )

) );
}