Add a failing test for minifying nested orphaned pseudo #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whitespace in
& :hoverhas a semantic value - this is not equal to&:hoverand thus this whitespace should not be removed when minifying quasis.The problem is that
compressSymbolsis just too simplistic - parsing a language like CSS with RegExp is IMHO not the best idea in the long run as it loses the context in which particular symbols have been used and it's hard to develop further.I've prepared a fix for this problem in Emotion: emotion-js/emotion#1836 , we maybe could think of sharing the solution for this as the job is pretty much the same for both libraries. I'm afraid though that I won't have much time to abstract this away and port the solution here, but if you would like to do it I'm open for collaboration.