Skip to content

added typescript to the README #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

added typescript to the README #908

wants to merge 9 commits into from

Conversation

brnt-toast
Copy link
Contributor

just doing it now, so that we don't have to do it in the future when after we start moving to TS

quantizor
quantizor previously approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure makes sense

@quantizor
Copy link
Contributor

@brnt-toast needs a quick git merge and yarn to fix up the lockfile

@brnt-toast
Copy link
Contributor Author

should be on the same page now

faizaniqbalLC
faizaniqbalLC approved these changes Jun 2, 2023
View reviewed changes
Copy link

@faizaniqbalLC faizaniqbalLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed whole code and he just changed 1 line in readme.md and also upgraded some versions to lastest version in package.json and yarn.lock file

faizaniqbalLC
faizaniqbalLC approved these changes Jun 2, 2023
View reviewed changes
Copy link

@faizaniqbalLC faizaniqbalLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed whole code and he just changed 1 line in readme.md and also upgraded some versions to lastest version in package.json and yarn.lock file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantizor quantizor quantizor left review comments

+1 more reviewer

@faizaniqbalLC faizaniqbalLC faizaniqbalLC approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brnt-toast @quantizor @faizaniqbalLC