Adding collectRules to expose currently inserted styelsheet rules#112
Open
radicalpi wants to merge 1 commit intostyled-components:masterfrom
Open
Adding collectRules to expose currently inserted styelsheet rules#112radicalpi wants to merge 1 commit intostyled-components:masterfrom
radicalpi wants to merge 1 commit intostyled-components:masterfrom
Conversation
Collaborator
|
I am back working in vue + nuxt. Now I am trying to do this into nuxt plugin, but with no luck. Is that something that you assume is working or have you tested? |
Author
|
It was working to a degree when I created the PR. I later realized that the caveat was that it was adding the styles for any rendered components to a server-side style block, but it was still including all the styles dynamically in the browser. So, it does help prevent FOUC, as the styles are present upfront, but they're included again which isn't ideal. I didn't end up digging much deeper toward a more complete solution. It's also been a while since I looked at this and I have largely moved away from using Vue Styled Components in newer work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a very basic module that returns all of the current rules off the Stylesheet singleton (While removing empty ones). The goal of this is to attempt to allow easier implementation of Server-Side Rendering and partially address #52
Example Usage in Nuxt:
This allows Nuxt/Vue Meta to inject all of the inserted rules from StyleSheet into the head of the page being rendered. Limitations being this will have to be done for each top-level "Page", but with access to the underlying rules, it should be easier to build more complete solutions.
I added this as a separate module rather than just exporting StyleSheet to allow for easier expansion in the future and to limit to scope of the exports.