Convert SessionToken to a String typealias#590
Merged
jhaven-stytch merged 3 commits intostytchauth:mainfrom Feb 5, 2026
Merged
Convert SessionToken to a String typealias#590jhaven-stytch merged 3 commits intostytchauth:mainfrom
jhaven-stytch merged 3 commits intostytchauth:mainfrom
Conversation
nidal-augment
commented
Jan 9, 2026
| if let opaqueCookieValue = storage.cookieValue(cookieName: SessionToken.Kind.opaque.name, date: date()) { | ||
| sessionToken = .opaque(opaqueCookieValue) | ||
| } | ||
| } |
jhaven-stytch
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After interacting with the
SessionTokensandSessionTokenobjects as an external consumer I felt that distinguishing between the token types internally was of zero value. TheSessionTokensobject store 2 tokens, one for each type that is named and that is all the differentiation we really need. Therefore I felt that theSessionTokencould be made a simple String type alias and we would get all the same value from it.Checklist: