Skip to content

Conversation

@marcosch27
Copy link

@marcosch27 marcosch27 commented Sep 17, 2025

Proposed Changes

Hello everyone,

This PR is one of two contributions resulting from my Master’s Thesis.

In this PR, I’ve added a new roughness-induced transition model through a roughness amplification factor transport (AFT), based on the approach described in this paper by Langel et al.

The attached PDF includes documentation as well as validation results for the NACA0012 transitional test case with roughness strips. Further validation test cases have been performed and are reported in my Master's Thesis, which will be available in the following months. If needed, I can add a validation test case to the SU2 suite.

Please let me know if any modifications are needed.

Related Work

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted
Copy link
Contributor

Thanks for the contribution! So what does the result look like if we do not use this extension?
If you feel generous, please also consider adding some info to the theory section. Many of these models are not visible to the casual user.
https://su2code.github.io/docs_v7/Theory/#turbulence-modeling

@joshkellyjak
Copy link
Contributor

A testcase for these features would be very beneficial also!

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contributions 👍 I'll review this PR once the other one is ready to merge.
Add yourself to the AUTHORS.md list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants