Skip to content
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
6142816
Add MUSCL_KAPPA options to config class and template
bmunguia Oct 9, 2025
9010bba
Apply kappa-blending to Roe MUSCL reconstruction
bmunguia Oct 9, 2025
f13f486
Merge branch 'develop' into feature_muscl_kappa
bmunguia Oct 11, 2025
92a698c
Fix initializer list order
bmunguia Oct 11, 2025
ea18471
Extend U-MUSCL to SIMD edge and point limiters
bmunguia Oct 12, 2025
3cdc4f7
Extend U-MUSCL extrapolation to non-SIMD upwind residuals
bmunguia Oct 13, 2025
7a145f4
Fix central difference scaling
bmunguia Oct 13, 2025
548fe02
U-MUSCL reconstruction when calculating point limiters
bmunguia Oct 13, 2025
e9081b0
Apply NK relaxation after limiting
bmunguia Oct 13, 2025
1c7c56a
Cleanup
bmunguia Oct 13, 2025
6c9f5b7
Bug fix
bmunguia Oct 13, 2025
e5609c8
Fix VA limiter projection scaling
bmunguia Oct 13, 2025
ab54718
Fix centered difference scaling, and document it
bmunguia Oct 13, 2025
176fdc7
Move MUSCL reconstruction to CSolver
bmunguia Oct 14, 2025
527b64a
Apply relaxation before limiter
bmunguia Oct 14, 2025
3f8e7b5
Update computeLimiters signature, and remove unused include
bmunguia Oct 14, 2025
a54a57c
Print umuscl kappa with limiter info
bmunguia Oct 15, 2025
ac5dd0e
Add regressions with u-muscl reconstruction
bmunguia Oct 16, 2025
a48c71f
Update regression config
bmunguia Oct 16, 2025
3c21aa7
Update regression config
bmunguia Oct 16, 2025
5fa7479
Update regression test values
bmunguia Oct 16, 2025
526e5dd
Fix FSI regression grad file
bmunguia Oct 16, 2025
6cd0abb
Merge branch 'develop' into feature_muscl_kappa
bmunguia Oct 21, 2025
53707ae
Address CConfig and CSolver comments
bmunguia Oct 21, 2025
26f4052
Remove unused variables
bmunguia Oct 21, 2025
c9910dd
Address regression comments
bmunguia Oct 21, 2025
1335c29
Address numerics comments
bmunguia Oct 21, 2025
fcc633f
Update regressions
bmunguia Oct 22, 2025
397f8b2
Update regression workflow
bmunguia Oct 22, 2025
3914991
Update regression test vals
bmunguia Oct 22, 2025
b82d8ea
Remove unused regression configs
bmunguia Oct 22, 2025
f96e641
Update NACA 0012 RANS configs
bmunguia Oct 23, 2025
9ffa8ec
Update other NACA 0012 RANS configs to use binary restart
bmunguia Oct 23, 2025
9afd97f
Update regression test vals
bmunguia Oct 23, 2025
cd045bd
Update n0012 AD regression test vals
bmunguia Oct 23, 2025
dde3fae
Revert regression TestCases branch
bmunguia Oct 23, 2025
a359f75
Update adjoint configs to use same kappa as primal
bmunguia Oct 23, 2025
f46d75c
Update adjoint regression test vals
bmunguia Oct 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ jobs:
uses: docker://ghcr.io/su2code/su2/test-su2:250717-1402
with:
# -t <Tutorials-branch> -c <Testcases-branch>
args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}}
args: -b ${{github.ref}} -t develop -c feature_muscl_kappa -s ${{matrix.testscript}}
- name: Cleanup
uses: docker://ghcr.io/su2code/su2/test-su2:250717-1402
with:
Expand Down Expand Up @@ -260,7 +260,7 @@ jobs:
uses: docker://ghcr.io/su2code/su2/test-su2:250717-1402
with:
# -t <Tutorials-branch> -c <Testcases-branch>
args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}} -a "--tapetests"
args: -b ${{github.ref}} -t develop -c feature_muscl_kappa -s ${{matrix.testscript}} -a "--tapetests"
- name: Cleanup
uses: docker://ghcr.io/su2code/su2/test-su2:250717-1402
with:
Expand Down Expand Up @@ -306,7 +306,7 @@ jobs:
uses: docker://ghcr.io/su2code/su2/test-su2-tsan:250717-1402
with:
# -t <Tutorials-branch> -c <Testcases-branch>
args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}} -a "--tsan"
args: -b ${{github.ref}} -t develop -c feature_muscl_kappa -s ${{matrix.testscript}} -a "--tsan"
- name: Cleanup
uses: docker://ghcr.io/su2code/su2/test-su2-tsan:250717-1402
with:
Expand Down Expand Up @@ -351,7 +351,7 @@ jobs:
uses: docker://ghcr.io/su2code/su2/test-su2-asan:250717-1402
with:
# -t <Tutorials-branch> -c <Testcases-branch>
args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}} -a "--asan"
args: -b ${{github.ref}} -t develop -c feature_muscl_kappa -s ${{matrix.testscript}} -a "--asan"
- name: Cleanup
uses: docker://ghcr.io/su2code/su2/test-su2-asan:250717-1402
with:
Expand Down
61 changes: 22 additions & 39 deletions Common/include/CConfig.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ class CConfig {
DIFFUSIVITYMODEL Kind_Diffusivity_Model; /*!< \brief Kind of the mass diffusivity Model */
FREESTREAM_OPTION Kind_FreeStreamOption; /*!< \brief Kind of free stream option to choose if initializing with density or temperature */
MAIN_SOLVER Kind_Solver; /*!< \brief Kind of solver: Euler, NS, Continuous adjoint, etc. */
LIMITER Kind_SlopeLimit, /*!< \brief Global slope limiter. */
LIMITER Kind_SlopeLimit, /*!< \brief Slope limiter (for the runtime eq. system). */
Kind_SlopeLimit_Flow, /*!< \brief Slope limiter for flow equations.*/
Kind_SlopeLimit_Turb, /*!< \brief Slope limiter for the turbulence equation.*/
Kind_SlopeLimit_AdjTurb, /*!< \brief Slope limiter for the adjoint turbulent equation.*/
Expand Down Expand Up @@ -555,12 +555,12 @@ class CConfig {
Kind_ConvNumScheme_AdjTurb, /*!< \brief Centered or upwind scheme for the adjoint turbulence model. */
Kind_ConvNumScheme_Species, /*!< \brief Centered or upwind scheme for the species model. */
Kind_ConvNumScheme_Template, /*!< \brief Centered or upwind scheme for the level set equation. */
Kind_FEM, /*!< \brief Finite element scheme for the flow equations. */
Kind_FEM, /*!< \brief Finite element scheme for the flow equations (for the runtime eq. system). */
Kind_FEM_Flow, /*!< \brief Finite element scheme for the flow equations. */
Kind_Matrix_Coloring; /*!< \brief Type of matrix coloring for sparse Jacobian computation. */

CENTERED
Kind_Centered, /*!< \brief Centered scheme. */
Kind_Centered, /*!< \brief Centered scheme (for the runtime eq. system). */
Kind_Centered_Flow, /*!< \brief Centered scheme for the flow equations. */
Kind_Centered_AdjFlow, /*!< \brief Centered scheme for the adjoint flow equations. */
Kind_Centered_Turb, /*!< \brief Centered scheme for the turbulence model. */
Expand All @@ -577,7 +577,7 @@ class CConfig {
bool Energy_Equation; /*!< \brief Solve the energy equation for incompressible flows. */

UPWIND
Kind_Upwind, /*!< \brief Upwind scheme. */
Kind_Upwind, /*!< \brief Upwind scheme (for the runtime eq. system). */
Kind_Upwind_Flow, /*!< \brief Upwind scheme for the flow equations. */
Kind_Upwind_AdjFlow, /*!< \brief Upwind scheme for the adjoint flow equations. */
Kind_Upwind_Turb, /*!< \brief Upwind scheme for the turbulence model. */
Expand All @@ -586,13 +586,19 @@ class CConfig {
Kind_Upwind_Heat, /*!< \brief Upwind scheme for the heat transfer model. */
Kind_Upwind_Template; /*!< \brief Upwind scheme for the template model. */

bool MUSCL, /*!< \brief MUSCL scheme .*/
bool MUSCL, /*!< \brief MUSCL scheme (for the runtime eq. system). */
MUSCL_Flow, /*!< \brief MUSCL scheme for the flow equations.*/
MUSCL_Turb, /*!< \brief MUSCL scheme for the turbulence equations.*/
MUSCL_Heat, /*!< \brief MUSCL scheme for the (fvm) heat equation.*/
MUSCL_AdjFlow, /*!< \brief MUSCL scheme for the adj flow equations.*/
MUSCL_AdjTurb; /*!< \brief MUSCL scheme for the adj turbulence equations.*/
bool MUSCL_Species; /*!< \brief MUSCL scheme for the species equations.*/
MUSCL_AdjTurb, /*!< \brief MUSCL scheme for the adj turbulence equations.*/
MUSCL_Species; /*!< \brief MUSCL scheme for the species equations.*/
su2double MUSCL_Kappa, /*!< \brief Blending coefficient for U-MUSCL scheme (for the runtime eq. system). */
MUSCL_Kappa_Flow, /*!< \brief Blending coefficient for U-MUSCL scheme for the flow equations.*/
MUSCL_Kappa_Turb, /*!< \brief Blending coefficient for U-MUSCL scheme for the turbulence equations.*/
MUSCL_Kappa_Heat, /*!< \brief Blending coefficient for U-MUSCL scheme for the (fvm) heat equation.*/
MUSCL_Kappa_AdjFlow, /*!< \brief Blending coefficient for U-MUSCL scheme for the adj flow equations.*/
MUSCL_Kappa_Species; /*!< \brief Blending coefficient for U-MUSCL scheme for the species equations.*/
bool Use_Accurate_Jacobians; /*!< \brief Use numerically computed Jacobians for AUSM+up(2) and SLAU(2). */
bool Use_Accurate_Turb_Jacobians; /*!< \brief Use numerically computed Jacobians for standard SA turbulence model. */
bool EulerPersson; /*!< \brief Boolean to determine whether this is an Euler simulation with Persson shock capturing. */
Expand Down Expand Up @@ -2457,11 +2463,12 @@ class CConfig {
* \param[in] val_kind_upwind - If upwind scheme, kind of upwind scheme (Roe, etc.).
* \param[in] val_kind_slopelimit - If upwind scheme, kind of slope limit.
* \param[in] val_muscl - Define if we apply a MUSCL scheme or not.
* \param[in] val_muscl_kappa - Define the blending coefficient for the MUSCL scheme.
* \param[in] val_kind_fem - If FEM, what kind of FEM discretization.
*/
void SetKind_ConvNumScheme(unsigned short val_kind_convnumscheme, CENTERED val_kind_centered,
UPWIND val_kind_upwind, LIMITER val_kind_slopelimit,
bool val_muscl, unsigned short val_kind_fem);
bool val_muscl, su2double val_muscl_kappa, unsigned short val_kind_fem);

/*!
* \brief Get the value of limiter coefficient.
Expand Down Expand Up @@ -4617,54 +4624,30 @@ class CConfig {

/*!
* \brief Get if the upwind scheme used MUSCL or not.
* \note This is the information that the code will use, the method will
* change in runtime depending of the specific equation (direct, adjoint,
* linearized) that is being solved.
* \return MUSCL scheme.
*/
bool GetMUSCL_Flow(void) const { return MUSCL_Flow; }

/*!
* \brief Get if the upwind scheme used MUSCL or not.
* \note This is the information that the code will use, the method will
* change in runtime depending of the specific equation (direct, adjoint,
* linearized) that is being solved.
* \return MUSCL scheme.
*/
bool GetMUSCL_Heat(void) const { return MUSCL_Heat; }

/*!
* \brief Get if the upwind scheme used MUSCL or not.
* \note This is the information that the code will use, the method will
* change in runtime depending of the specific equation (direct, adjoint,
* linearized) that is being solved.
* \return MUSCL scheme.
*/
bool GetMUSCL_Turb(void) const { return MUSCL_Turb; }

/*!
* \brief Get if the upwind scheme used MUSCL or not.
* \return MUSCL scheme.
*/
bool GetMUSCL_Species(void) const { return MUSCL_Species; }
bool GetMUSCL_AdjFlow(void) const { return MUSCL_AdjFlow; }

/*!
* \brief Get if the upwind scheme used MUSCL or not.
* \brief Get the blending coefficient for the U-MUSCL scheme.
* \note This is the information that the code will use, the method will
* change in runtime depending of the specific equation (direct, adjoint,
* linearized) that is being solved.
* \return MUSCL scheme.
* \return Blending coefficient for the U-MUSCL scheme.
*/
bool GetMUSCL_AdjFlow(void) const { return MUSCL_AdjFlow; }
su2double GetMUSCL_Kappa(void) const { return MUSCL_Kappa; }

/*!
* \brief Get if the upwind scheme used MUSCL or not.
* \note This is the information that the code will use, the method will
* change in runtime depending of the specific equation (direct, adjoint,
* linearized) that is being solved.
* \return MUSCL scheme.
* \brief Get the blending coefficient for the MUSCL scheme.
* \return Blending coefficient for the MUSCL scheme.
*/
bool GetMUSCL_AdjTurb(void) const { return MUSCL_AdjTurb; }
su2double GetMUSCL_Kappa_Flow(void) const { return MUSCL_Kappa_Flow; }

/*!
* \brief Get whether to "Use Accurate Jacobians" for AUSM+up(2) and SLAU(2).
Expand Down
Loading