Skip to content

Fix logic bugs in 2D Actuator Disk preprocessing and Periodic Solver #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shbhmexe wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix logic bugs in 2D Actuator Disk preprocessing and Periodic Solver #2694

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5484448
Fix in 2D Actuator Disk splitting and Periodic LS Solver
shbhmexe Jan 11, 2026
59d0825
Fix bugs in 2D Actuator Disk and Periodic Solver
shbhmexe Jan 11, 2026
ff332fe
Fix style: split multiple statements to separate lines in CSolver.cpp
shbhmexe Jan 11, 2026
15b77ed
Remove unused variable r23_b to fix build error
shbhmexe Jan 12, 2026
57f595e
Delete PR_REPORT.md
shbhmexe Jan 12, 2026
5d90b26
Merge branch 'develop' into fix/2d-actuator-disk-and-periodic-solver-…
bigfooted Jan 12, 2026
d350a8a
Revert CSolver.cpp changes, keep only CSU2ASCIIMeshReaderFVM.cpp fixes
shbhmexe Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Common/src/geometry/meshreader/CSU2ASCIIMeshReaderFVM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,7 @@ void CSU2ASCIIMeshReaderFVM::SplitActuatorDiskSurface() {
}

sort(ActDiskPoint_Front.begin(), ActDiskPoint_Front.end());
auto it = unique(ActDiskPoint_Front.begin(), ActDiskPoint_Front.end());
ActDiskPoint_Front.resize(it - ActDiskPoint_Front.begin());
/* unique call removed to preserve frequency information for perimeter detection */

/*--- Check the begning of the list ---*/

Expand All @@ -268,13 +267,14 @@ void CSU2ASCIIMeshReaderFVM::SplitActuatorDiskSurface() {
bool Check_1 = !((ActDiskPoint_Front[iPoint] == ActDiskPoint_Front[iPoint - 1]));
bool Check_2 = !((ActDiskPoint_Front[iPoint] == ActDiskPoint_Front[iPoint + 1]));
if ((Check_1 && Check_2)) {
PerimeterPoint.push_back(ActDiskPoint_Front[iEdge]);
PerimeterPoint.push_back(ActDiskPoint_Front[iPoint]);
}
}

/*--- Check the end of the list ---*/

if (!((EdgeBegin[ActDiskPoint_Front.size() - 1] == EdgeBegin[ActDiskPoint_Front.size() - 2]))) {
if (!((ActDiskPoint_Front[ActDiskPoint_Front.size() - 1] ==
ActDiskPoint_Front[ActDiskPoint_Front.size() - 2]))) {
PerimeterPoint.push_back(ActDiskPoint_Front[ActDiskPoint_Front.size() - 1]);
}

Expand Down