fix: #107 nc 30 compatibility #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarinier
commented
Apr 25, 2025
smarinier
commented
- use IAppConfig
- use Application::ID
- use modern PHP 8 constructors
- minimum version is now NC 29
Author
|
Hi @sualko, one little spring refresh on the piwik app. |
|
We waiting for this package before upgrading so we can cleanup upgrade to NC 30. Any reason we not bumping this to NC 31. |
Contributor
|
@sualko Can this be merged please? |
Author
|
Hi @CodeShakingSheep, sualko doesn't really have time to deal with that project anymore. We are currently in discussion with him to take charge of it. The 31 compatibility is ready, and will be pushed soon. Yours, |
|
I would like to use this app with NC32, any news on a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.