Django10 support #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed app, added keepalive ping
variable name conflict
variable naming error
Changed from datetime objects to timestamps allowing the use of serializers.JSONSerializer for session serialization (as it the default serialization since Django 1.6.x). Probably faster as well.
Update middleware.py
Add in unlocalize
Session keep alive ping breaks if l10n is on and use_thousands_separator=True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Django 1.10
Since Django 1.10,
it raises errors like
object() takes no parametersif the custom middleware is not inherited
MiddlewareMixin.Similar question: http://stackoverflow.com/a/41634798/1105489