Skip to content

Conversation

@MSAdministrator
Copy link
Member

@MSAdministrator MSAdministrator commented Dec 12, 2025

Description

Adding a new rule for coverage of PDFs used for banking/transfer from a freemail provider.

Detects PDF attachments containing banking terminology such as SWIFT codes, account numbers, and payment references from free email providers. These attachments often contain fraudulent payment instructions or fake banking documents used in business email compromise attacks.

Associated samples

Associated hunts

@MSAdministrator MSAdministrator self-assigned this Dec 12, 2025
@MSAdministrator MSAdministrator requested a review from a team as a code owner December 12, 2025 16:38
@MSAdministrator MSAdministrator added the in-test-rules PR is in our testing suite to collect telemetry label Dec 12, 2025
github-actions bot added a commit that referenced this pull request Dec 12, 2025
@MSAdministrator
Copy link
Member Author

New Hunt

@MSAdministrator MSAdministrator added the review-needed Indicates that a PR is waiting for review label Dec 16, 2025
@IndiaAce
Copy link
Member

I'm seeing a lot of telemetry in test rules that is marked likely benign here, I'm unable to load the sample sets to SWS but I think this might need some revision. I'm going to remove the review-needed label

@IndiaAce IndiaAce removed the review-needed Indicates that a PR is waiting for review label Dec 18, 2025
github-actions bot added a commit that referenced this pull request Dec 22, 2025
@MSAdministrator MSAdministrator added the review-needed Indicates that a PR is waiting for review label Dec 29, 2025
@zoomequipd
Copy link
Member

beyond the suggested changes, where are mostly syntax based, the rule appears to match on a bunch of benign samples.

going to remove the review-needed label until benign matches are addressed

@zoomequipd zoomequipd removed the review-needed Indicates that a PR is waiting for review label Jan 8, 2026
github-actions bot added a commit that referenced this pull request Jan 12, 2026
github-actions bot added a commit that referenced this pull request Jan 12, 2026
@MSAdministrator
Copy link
Member Author

Mode results look good

@MSAdministrator MSAdministrator added the review-needed Indicates that a PR is waiting for review label Jan 12, 2026
github-actions bot added a commit that referenced this pull request Jan 12, 2026
github-actions bot added a commit that referenced this pull request Jan 12, 2026
github-actions bot added a commit that referenced this pull request Jan 12, 2026
Copy link
Member

@IndiaAce IndiaAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one very small nit and something I noticed with your regex... other than that I think this looks good to me!

github-actions bot added a commit that referenced this pull request Jan 14, 2026
@IndiaAce
Copy link
Member

I'm curious if the regex change is going to have larger impact, I'm going to remove r4r until we get some telemetry in test-ruels

@IndiaAce IndiaAce removed the review-needed Indicates that a PR is waiting for review label Jan 14, 2026
@MSAdministrator MSAdministrator added the review-needed Indicates that a PR is waiting for review label Jan 15, 2026
)
// or any defined org brands like: first.last.sublime@freemail
or any($org_slds, strings.icontains(sender.email.local_part, .))
or any($org_brand_names, strings.icontains(sender.email.local_part, .))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk the intention of org_brand_names would be common here.

I"m thinking of things like my company org_sld is tcitruck but my entry in org_brand_names is Traffic Consultants Inc

github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
…h banking and payment references from freemail sender
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
…nd payment references from freemail sender
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
…h banking and payment references from freemail sender
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
…nd payment references from freemail sender
@MSAdministrator MSAdministrator requested a review from a team as a code owner January 20, 2026 15:35
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 20, 2026
…with banking and payment references from freemail sender
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 20, 2026
…g and payment references from freemail sender
github-actions bot added a commit that referenced this pull request Jan 20, 2026
@MSAdministrator
Copy link
Member Author

I'm closing this one in favor of this newer rule #3809

github-actions bot added a commit that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-test-rules PR is in our testing suite to collect telemetry review-needed Indicates that a PR is waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants