Conversation
rchl
left a comment
rchl
left a comment
There was a problem hiding this comment.
It's good to also add a sublime-package.json which provides settings validation and completion (including in project files). Some existing example: https://github.com/sublimelsp/LSP-yaml/blob/master/sublime-package.json
| @classmethod | ||
| def needs_update_or_installation(cls) -> bool: | ||
| if get_binary_path().exists(): | ||
| return False | ||
| if shutil.which("wren-lsp"): | ||
| return False | ||
| return True | ||
|
|
There was a problem hiding this comment.
Most of the servers opt to specify version of the server in code and bring server updates through package updates (renovate bot takes care of creating PRs to update server).
This is especially relevant for servers that have settings to synchronize them with the current version of the server. This server doesn't seem have settings so maybe that argument is moot but did you consider that approach anyway?
I see that with current code the server will not be updated on its own unless user explicitly does that through custom command.
There was a problem hiding this comment.
The lsp is in beta phase right now with frequent updates. I opted for this approach so users can easily install the latest LSP version via a simple command, rather than releasing a new extension update every time there's new LSP release. I will definitely change the behaviour once we are in stable mode.
jossephus
force-pushed
the
feat/prepare-sublime-release
branch
from
1904d10 to
c045034
Compare
Read the setting from LSP-wren-lsp defaults and document config inline.
|
@rchl Thanks for your detailed review. |
|
Actually should also have sublime-commands file with command to open preferences. All LSP packages include that - https://github.com/sublimelsp/LSP-vue/blob/master/LSP-vue.sublime-commands |
2 participants
No description provided.