Skip to content

Automated backport of #1298: Replace slash with dot in ConfigMap keys for K8s compliance#1299

Merged
skitt merged 2 commits intosubmariner-io:release-0.22from
tpantelis:automated-backport-of-#1298-upstream-release-0.22
Mar 2, 2026
Merged

Automated backport of #1298: Replace slash with dot in ConfigMap keys for K8s compliance#1299
skitt merged 2 commits intosubmariner-io:release-0.22from
tpantelis:automated-backport-of-#1298-upstream-release-0.22

Conversation

@tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Feb 27, 2026

Backport of #1298 on release-0.22.

#1298: Replace slash with dot in ConfigMap keys for K8s compliance

For details on the backport process, see the backport requests page.

Summary by CodeRabbit

  • Changes
    • Updated workqueue configuration key format: delimiter changed from "/" to "." notation in configuration settings lookups, affecting rate-limiter and max-verbosity configurations.

Signed-off-by: Paddy <padgupta@microsoft.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1299/tpantelis/automated-backport-of-#1298-upstream-release-0.22

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0124aae and 1775e77.

📒 Files selected for processing (1)
  • pkg/workqueue/config.go

Walkthrough

Changes the ConfigMap key delimiter in ToConfigMapDataKey from a forward slash (/) to a dot (.) for workqueue configuration lookups. This modifies the string format of configuration keys used throughout the application without altering surrounding logic.

Changes

Cohort / File(s) Summary
ConfigMap Key Format
pkg/workqueue/config.go
Changed the key delimiter from "/" to "." in the ToConfigMapDataKey function, affecting how configuration values are retrieved from the ConfigMap (e.g., "workqueue.rate-limiter" instead of "workqueue/rate-limiter").

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • Oats87
  • sridhargaddam
  • skitt
  • vthapar
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: replacing slashes with dots in ConfigMap keys for Kubernetes compliance, and clarifies it's a backport of PR #1298.
Actionable Comments Resolved ✅ Passed The pull request contains no actionable reviewer comments. PR objectives explicitly state no other reviewer comments are present, and investigation confirms no outstanding action items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skitt skitt enabled auto-merge (rebase) March 2, 2026 15:46
@skitt skitt merged commit d244cfc into submariner-io:release-0.22 Mar 2, 2026
18 of 19 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1299/tpantelis/automated-backport-of-#1298-upstream-release-0.22]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants