Skip to content

Automated backport of #1298: Replace slash with dot in ConfigMap keys for K8s compliance#1300

Merged
skitt merged 2 commits intosubmariner-io:release-0.21from
tpantelis:automated-backport-of-#1298-upstream-release-0.21
Mar 2, 2026
Merged

Automated backport of #1298: Replace slash with dot in ConfigMap keys for K8s compliance#1300
skitt merged 2 commits intosubmariner-io:release-0.21from
tpantelis:automated-backport-of-#1298-upstream-release-0.21

Conversation

@tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Feb 27, 2026

Backport of #1298 on release-0.21.

#1298: Replace slash with dot in ConfigMap keys for K8s compliance

For details on the backport process, see the backport requests page.

Summary by CodeRabbit

  • Bug Fixes
    • Updated configuration key formatting in workqueue configuration maps to use dot notation instead of slash notation.

Signed-off-by: Paddy <padgupta@microsoft.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1300/tpantelis/automated-backport-of-#1298-upstream-release-0.21

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4c3f74 and fb29e53.

📒 Files selected for processing (1)
  • pkg/workqueue/config.go

Walkthrough

Modified ConfigMap key formatting in the ToConfigMapDataKey function from slash-delimited to dot-delimited format, changing the pattern from %s.workqueue/%s to %s.workqueue.%s. No functional logic or control flow changes.

Changes

Cohort / File(s) Summary
Configuration Key Formatting
pkg/workqueue/config.go
Changed ToConfigMapDataKey format string from slash-delimited to dot-delimited pattern for ConfigMap key construction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • sridhargaddam
  • tpantelis
  • Oats87
  • vthapar
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: replacing slashes with dots in ConfigMap keys for Kubernetes compliance, which matches the single file modification in the changeset.
Actionable Comments Resolved ✅ Passed Pull request contains only an automated notification from submariner-bot; no actionable comments requiring resolution.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skitt skitt enabled auto-merge (rebase) March 2, 2026 15:45
@skitt skitt merged commit ee64f5a into submariner-io:release-0.21 Mar 2, 2026
18 of 19 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1300/tpantelis/automated-backport-of-#1298-upstream-release-0.21]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants