Skip to content

Automated backport of #1298: Replace slash with dot in ConfigMap keys for K8s compliance#1301

Merged
skitt merged 2 commits intosubmariner-io:release-0.20from
tpantelis:automated-backport-of-#1298-upstream-release-0.20
Mar 2, 2026
Merged

Automated backport of #1298: Replace slash with dot in ConfigMap keys for K8s compliance#1301
skitt merged 2 commits intosubmariner-io:release-0.20from
tpantelis:automated-backport-of-#1298-upstream-release-0.20

Conversation

@tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Feb 27, 2026

Backport of #1298 on release-0.20.

#1298: Replace slash with dot in ConfigMap keys for K8s compliance

For details on the backport process, see the backport requests page.

Summary by CodeRabbit

  • Bug Fixes
    • Updated config map data key formatting to use dot separators instead of slash separators for improved consistency and readability.

Signed-off-by: Paddy <padgupta@microsoft.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1301/tpantelis/automated-backport-of-#1298-upstream-release-0.20

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 266b9b8 and 570e6bf.

📒 Files selected for processing (1)
  • pkg/workqueue/config.go

Walkthrough

The ToConfigMapDataKey function in pkg/workqueue/config.go is updated to construct config map data keys using dot separators (.) instead of slash separators (/) when combining prefix and name values.

Changes

Cohort / File(s) Summary
Key Format Update
pkg/workqueue/config.go
Changed ToConfigMapDataKey function to use dot separator instead of slash when formatting config map data keys.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • vthapar
  • sridhargaddam
  • Oats87
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing slashes with dots in ConfigMap keys for Kubernetes compliance, and indicates it is a backport of PR #1298.
Actionable Comments Resolved ✅ Passed All actionable comments are resolved. No TODO, FIXME, HACK markers found in code and no human reviewer comments requiring action present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skitt skitt enabled auto-merge (rebase) March 2, 2026 15:45
@skitt skitt merged commit 2885a99 into submariner-io:release-0.20 Mar 2, 2026
18 of 19 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1301/tpantelis/automated-backport-of-#1298-upstream-release-0.20]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants