Skip to content

Comments

Modify webhook bot and CodeRabbit workflow to handle konflux PRs#242

Merged
skitt merged 1 commit intosubmariner-io:develfrom
tpantelis:konfux_pr_triggers
Feb 6, 2026
Merged

Modify webhook bot and CodeRabbit workflow to handle konflux PRs#242
skitt merged 1 commit intosubmariner-io:develfrom
tpantelis:konfux_pr_triggers

Conversation

@tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Feb 6, 2026

...same as they do for dependabot PRs.

Summary by CodeRabbit

  • Chores

    • Updated GitHub Actions workflow configuration to support additional automated service as a workflow trigger.
    • Improved pull request processing logs to include author information for enhanced traceability during label application.
  • New Features

    • Extended automated pull request detection to recognize and properly label requests from additional bot services, expanding the range of automated workflows supported.

...same they do for dependabot PRs.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@submariner-bot
Copy link

🤖 Created branch: z_pr242/tpantelis/konfux_pr_triggers

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

Walkthrough

The PR extends the GitHub Actions workflow to allow an additional bot actor to trigger code reviews, and adds detection for Konflux bot-authored PRs to apply the "ready-to-test" label alongside existing Dependabot PR handling in the pull request handler.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/coderabbit-trigger.yml
Expanded job condition to permit the red-hat-konflux-kflux-prd-rh02[bot] actor to trigger the workflow in addition to existing actors.
Pull Request Handler
pkg/handler/pullrequest/handler.go
Added isKonfluxBotPR() helper function to detect Konflux bot-authored PRs and integrated it into the label-application logic to apply "ready-to-test" label for both Dependabot and Konflux bot PRs on open events. Enhanced logging to include PR author login in label application and error messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Oats87
  • sridhargaddam
  • skitt

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Actionable Comments Resolved ❓ Inconclusive Unable to verify actionable comments due to repository access issues and incomplete context. The provided materials include a high-level summary of changes and mention three reviewers, but the comments section only documents an automated system message about branch creation with no detail on actual review feedback. Provide the complete list of review comments, suggestions, or action items from pull request reviewers via GitHub PR page or API, including screenshots or discussion thread exports.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes across both modified files: updating the CodeRabbit workflow to allow the Konflux bot and modifying the webhook handler to treat Konflux bot PRs like Dependabot PRs.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tpantelis tpantelis requested a review from dfarrell07 February 6, 2026 04:13
@tpantelis
Copy link
Contributor Author

@coderabbitai in your prior review comment, #242 (comment), you state that a Pre-merge checks failed - which one failed? Were you referring to the "Actionable Comments Resolved" check with status "Inconclusive"? If so, I don't understand the reason for this - can you clarify?

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Fetch the specific comment mentioned by the user
echo "=== Fetching comment 3857857657 ==="
gh api /repos/submariner-io/submariner-bot/issues/comments/3857857657 --jq '.body'

echo ""
echo "=== Checking PR status and checks ==="
# Get PR details including check runs
gh pr view 242 --repo submariner-io/submariner-bot --json statusCheckRollup,reviewDecision,state

echo ""
echo "=== Listing recent review comments ==="
# Get recent review comments to understand context
gh api /repos/submariner-io/submariner-bot/pulls/242/comments --jq '.[] | {id: .id, user: .user.login, body: .body[0:200], created_at: .created_at}' | head -20

Length of output: 12125


@tpantelis Yes, you're correct! I was referring to the "Actionable Comments Resolved" check that showed status "❓ Inconclusive" in my pre-merge checks summary.

Looking at the comment I posted, I marked it as inconclusive with this explanation: "Unable to verify actionable comments due to repository access issues and incomplete context."

However, reviewing the current state of the PR:

  • ✅ The PR is approved
  • ✅ All CI/CD checks are passing (Build, Linting, DCO, Branch Checks, etc.)
  • ✅ CodeRabbit status is SUCCESS
  • ✅ There are no actionable review comments to resolve

The "Inconclusive" status was overly cautious on my part. At the time I generated that check, I couldn't fully verify the review comments status, but looking at the actual PR state now, there are no unresolved actionable comments. The check should have been marked as "Passed" instead of "Inconclusive."

Your PR is actually in good shape and ready to merge. The pre-merge warning was a false alarm - all real checks have passed, and there are no blocking issues.

I apologize for the confusion! 🐰


🧠 Learnings used
Learnt from: CR
Repo: submariner-io/submariner-bot PR: 0
File: coderabbit-custom-pre-merge-checks-unique-id-file-non-traceable-F7F2B60C-1728-4C9A-8889-4F2235E186CA.txt:0-0
Timestamp: 2025-12-12T19:25:11.883Z
Learning: All actionable comments must be resolved before code can pass review

@skitt skitt merged commit c3288c3 into submariner-io:devel Feb 6, 2026
8 checks passed
@submariner-bot
Copy link

🤖 Closed branches: [z_pr242/tpantelis/konfux_pr_triggers]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants