Harden setup.sh and update README documentation#382
Open
kevmoo wants to merge 1 commit intosubosito:mainfrom
Open
Harden setup.sh and update README documentation#382kevmoo wants to merge 1 commit intosubosito:mainfrom
kevmoo wants to merge 1 commit intosubosito:mainfrom
Conversation
- Added 'set -o pipefail' to setup.sh for better error propagation - Hardened curl calls with -fL for robust downloads and redirect handling - Simplified positional argument parsing using 'shift' - Added 'GIT_SOURCE' to environment and test mode outputs - Fixed overlapping 'pub-cache-path' example in README.md - Documented 'GIT_SOURCE' output in README.md examples
Author
|
I did double-check things here, but this is mostly Gemini-generated. FYI. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Owner
|
sorry for the comment noise @kevmoo, thanks for the PR 👍 |
Author
|
Do worries, @subosito ! We use this everywhere. Run w/ it as you will. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Improvements