Skip to content

fix: improve validation error details in validateCommonProjectManifest #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lil-Duckling-22 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: improve validation error details in validateCommonProjectManifest #2966

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b26630d
fix: improve validation error details in validateCommonProjectManifest
Lil-Duckling-22 Nov 15, 2025
ff31007
Create load.spec.ts
Lil-Duckling-22 Dec 7, 2025
3dc59e7
Update load.ts
Lil-Duckling-22 Dec 10, 2025
0616ebe
Update utils.ts
Lil-Duckling-22 Dec 10, 2025
8f8b20f
Update base.ts
Lil-Duckling-22 Dec 10, 2025
7aa34f3
Update load.spec.ts
Lil-Duckling-22 Dec 10, 2025
dfc70a0
Update utils.ts
Lil-Duckling-22 Dec 20, 2025
de9ef18
Update load.ts
Lil-Duckling-22 Dec 20, 2025
02c3d2a
Update base.ts
Lil-Duckling-22 Dec 20, 2025
c5c19c7
Update load.spec.ts
Lil-Duckling-22 Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/common/src/project/load.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import fs from 'fs';
import path from 'path';
import {ProjectManifestV1_0_0} from '@subql/types-core';
import {plainToClass} from 'class-transformer';
import {validateSync} from 'class-validator';
import {validateSync, ValidationError} from 'class-validator';
import yaml from 'js-yaml';
import {gte} from 'semver';
import {CommonProjectManifestV1_0_0Impl} from '../';
Expand Down Expand Up @@ -91,8 +91,11 @@ export function validateCommonProjectManifest(raw: unknown): void {
const projectManifest = plainToClass<CommonProjectManifestV1_0_0Impl, unknown>(CommonProjectManifestV1_0_0Impl, raw);
const errors = validateSync(projectManifest, {whitelist: true});
if (errors?.length) {
// TODO: print error details
const errorMsgs = errors.map((e) => e.toString()).join('\n');
const errorMsgs = errors.map((error: ValidationError) => {
const property = error.property;
const constraints = error.constraints ? Object.values(error.constraints).join(', ') : 'unknown constraint';
return ` - ${property}: ${constraints}`;
}).join('\n');
throw new Error(`project validation failed.\n${errorMsgs}`);
}
}
Loading