[gateway] add tests for gateway chart#251
Merged
DanielRaapDev merged 8 commits intomainfrom Feb 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit tests for the gateway Helm chart using the helm-unittest framework. The tests verify that the chart correctly renders Gateway resources with both minimal and complete configuration options.
Changes:
- Added test suite with basic and full configuration test cases
- Created test value files for different gateway configuration scenarios
- Updated chart version to 1.0.7 with changelog entry for new unit tests
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/gateway/tests/gateway_test.yaml | Adds test suite with assertions for basic and full gateway configurations, including API version handling |
| charts/gateway/tests/values/basic.yaml | Provides minimal test values with single HTTPS host configuration |
| charts/gateway/tests/values/full.yaml | Provides comprehensive test values covering all gateway configuration options |
| charts/gateway/Chart.yaml | Bumps version to 1.0.7 and documents addition of unit tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mode: Terminate | ||
| certificateRefs: | ||
| - name: other-certificate | ||
| namspace: secret-ns |
There was a problem hiding this comment.
Corrected spelling of 'namspace' to 'namespace'.
Suggested change
| namspace: secret-ns | |
| namespace: secret-ns |
| - group: foo.example.com | ||
| kind: SpecialSecret | ||
| name: other-certificate | ||
| namspace: secret-ns |
There was a problem hiding this comment.
Corrected spelling of 'namspace' to 'namespace'.
Suggested change
| namspace: secret-ns | |
| namespace: secret-ns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.