Conversation
This brings Flowbite::Input::Hint in line with how Flowbite::Input::Label works.
This changes the behavior and implementation of Flowbite::InputField#hint to be in line with #label and #input.
This is simpler and more consistent with the naming conventions we use in the other components.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the hint component to work more consistently with label and input components by accepting content through a block rather than a parameter, and standardizing how options are passed.
- Refactored
Flowbite::Input::Hintto accept content through a block instead of ahintparameter - Updated all hint usage across input field components to use the new hash-based format with
{content: "text"} - Standardized options passing from
hint_attributestooptionsparameter
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/components/flowbite/input/hint.rb | Core hint component refactored to accept content via block and use options parameter |
| app/components/flowbite/input_field.rb | Updated to use new hint format with content extraction and options merging |
| app/components/flowbite/input_field/checkbox.rb | Updated hint rendering to use new component API |
| app/components/flowbite/input_field/radio_button.rb | Updated hint rendering to use new component API |
| test/components/input/hint_test.rb | Updated tests to use block-based content and new options parameter |
| test/components/flowbite/input_field_test.rb | Updated tests to use new hash-based hint format |
| test/components/input_field/*.rb | Updated test files to use new hint format |
| demo/test/components/previews/input_field_preview.rb | Updated preview to use new hint format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
olepalm
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.