Merged
Conversation
We need this for Flowbite
Since we build the site in production mode and our form-inputs expects model tables to be created, we need a database in production.
We continously run into a > Information for cause: Propshaft::MissingAssetError (The asset > 'tailwind.css' was not found in the load path.): but only the first time we build the site in the same directory.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR sets up a static site generation capability for the demo application to serve as documentation, using Parklife to convert the Rails demo app into a static site deployable to GitHub Pages.
- Moved Lookbook from development-only to all environments to make it available in production
- Added GitHub Actions workflow configuration for static site deployment
- Created a preview layout template for component demonstrations
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| demo/config/routes.rb | Changed Lookbook mounting from development-only to available when gem is defined |
| demo/config/initializers/lookbook.rb | Added Lookbook configuration for preview layout |
| demo/config/database.yml | Updated production database path and removed extra whitespace |
| demo/app/views/layouts/preview.html.erb | Added new layout template for component previews |
| demo/Gemfile | Moved Lookbook from development group to production dependencies |
| .github/workflows/parklife.yml | Added Node.js setup and npm install step for static site generation |
Files not reviewed (1)
- demo/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's use our demo application as our documentation website, seeing how we've already got lookbook running there.
The demo site is a full Rails application, so we can use Parklife to generate a static site which can be deployed to GitHub pages 🤞