Merged
Conversation
Member
koppen
commented
Aug 21, 2025
Not sure where py-1.5 came from, but it should be py-2 to match the other sizes. See https://flowbite.com/docs/components/buttons/#button-sizes for details
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds previews for different button sizes in the demo and adjusts the small button padding. The change provides visual examples of all available button sizes (xs, sm, default, lg, xl) and standardizes the vertical padding for small buttons.
- Adds a new "Sizes" preview group showcasing all button size variants
- Updates the small button's vertical padding from
py-1.5topy-2
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| demo/test/components/previews/button_preview.rb | Adds preview methods for all button sizes with display configuration |
| app/components/flowbite/button.rb | Updates small button vertical padding for consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RasmusDWN
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.