Conversation
olepalm
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for include_blank and multiple options to the Select component, enabling users to render select dropdowns with a blank option and multi-select functionality.
- Added
include_blankparameter to allow rendering a blank option in select dropdowns - Added
multipleparameter to enable multi-select functionality - Updated both
Flowbite::Input::SelectandFlowbite::InputField::Selectclasses to support the new parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/components/flowbite/input/select.rb | Added include_blank and multiple parameters and properly passes them to Rails select helper via select_options |
| app/components/flowbite/input_field/select.rb | Updated to accept and forward include_blank and multiple parameters to the underlying Input::Select component |
| test/components/input/select_test.rb | Added test coverage for both include_blank and multiple functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
olepalm
force-pushed
the
add-options-for-select
branch
2 times, most recently
from
e7f0221 to
ee18939
Compare
koppen
requested changes
Nov 5, 2025
Member
koppen
left a comment
koppen
left a comment
There was a problem hiding this comment.
👍
Please update changelog as well, and if possible could we add an example to the previews?
This adds :include_blank and :multiple options to the Flowbite select input component, and updates the corresponding InputField component and tests accordingly. I am omitting the :prompt option, as it is not clear it works with the select helper. Tests seems to suggest it does not, but maybe with a select_tag helper it would.
olepalm
force-pushed
the
add-options-for-select
branch
2 times, most recently
from
d3d8fbb to
3972a61
Compare
olepalm
force-pushed
the
add-options-for-select
branch
from
3972a61 to
1a78fe7
Compare
koppen
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds :include_blank and :multiple options to the Flowbite select input component, and updates the corresponding InputField component and tests accordingly.
I am omitting the :prompt option, as it is not clear it works with the select helper. Tests seems to suggest it does not, but maybe with a select_tag helper it would.
Multiple preview
Include blank preview