Merged
Conversation
koppen
force-pushed
the
card_titles
branch
3 times, most recently
from
6d5e433 to
5ab0ad3
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds title functionality to the Flowbite::Card component, allowing cards to display an optional title either through an argument or a slot.
Key Changes:
- Added
renders_one :titleslot support to Card component with both argument-based and slot-based title rendering - Created new
Flowbite::Card::Titlecomponent for rendering card titles with default Flowbite styling - Updated card template to render titles conditionally
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| app/components/flowbite/card.rb | Added title slot declaration, title parameter to initializer, and helper methods (default_title, default_title_content, default_title_options, title?) to support title rendering |
| app/components/flowbite/card/title.rb | New component that renders an h5 title element with Flowbite's default card title styling |
| app/components/flowbite/card/card.html.erb | New template that renders the card container with optional title and content sections |
| test/components/flowbite/card_test.rb | Added three tests covering title argument usage, title options passing, and title slot functionality |
| demo/test/components/previews/card_preview.rb | Added preview examples for cards with title argument and title slot, along with grouping annotations |
| CHANGELOG.md | Documented the new title feature in the Unreleased section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koppen
force-pushed
the
card_titles
branch
2 times, most recently
from
b4790c4 to
784643d
Compare
By passing in the title as an argument you'll get the default rendering (which is a h5 tag with appropriate classes) without needing to manually render a Card::Title component in every card.
We want to be able to pass both content and options to the title element so we should follow the samme pattern as other components like InputField.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.